Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] health check #421

Merged
merged 12 commits into from
May 22, 2022
Merged

[feature] health check #421

merged 12 commits into from
May 22, 2022

Conversation

ztelur
Copy link
Contributor

@ztelur ztelur commented May 8, 2022

What this PR does:

  • rename model.Cluster to model.ClusterConfig, it's static cluster configuration
  • add cluster.Cluster, it's runtime cluster instance
  • add health checker

@PhilYue
Copy link
Member

PhilYue commented May 8, 2022

@PhilYue

cityiron
cityiron reviewed May 8, 2022
View reviewed changes
pkg/cluster/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
pkg/cluster/healthcheck/healthcheck.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #421 (985541e) into develop (672beda) will increase coverage by 1.05%.
The diff coverage is 54.83%.

@@             Coverage Diff             @@
##           develop     #421      +/-   ##
===========================================
+ Coverage    36.61%   37.67%   +1.05%     
===========================================
  Files           55       55              
  Lines         3654     3740      +86     
===========================================
+ Hits          1338     1409      +71     
- Misses        2164     2174      +10     
- Partials       152      157       +5
Impacted Files Coverage Δ
pkg/server/cluster_manager.go 38.29% <51.72%> (+2.76%) ⬆️
pkg/config/xds/apiclient/grpc.go 17.94% <100.00%> (ø)
pkg/config/xds/cds.go 52.89% <100.00%> (+0.39%) ⬆️
pkg/server/pixiu_start.go 3.22% <0.00%> (-0.23%) ⬇️
pkg/server/listener_manager.go 0.00% <0.00%> (ø)
pkg/common/extension/filter/filter.go 15.21% <0.00%> (ø)
...oregistry/registry/zookeeper/interface_listener.go 10.00% <0.00%> (ø)
...registry/zookeeper/application_service_listener.go 0.00% <0.00%> (ø)
pkg/config/xds/lds.go 58.03% <0.00%> (+51.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 672beda...985541e. Read the comment docs.

@mark4z mark4z requested a review from PhilYue May 21, 2022 07:45
@AlexStocks AlexStocks merged commit a274007 into apache:develop May 22, 2022
@PhilYue PhilYue added this to the v0.5.1 milestone Jul 9, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@AlexStocks
Merge pull request apache#421 from ztelur/feature-health-check-2
9478d7b 
[feature] health check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cityiron cityiron cityiron left review comments

@mark4z mark4z mark4z approved these changes

@ma642 ma642 ma642 approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@PhilYue PhilYue Awaiting requested review from PhilYue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.
7 participants
@ztelur @PhilYue @codecov-commenter @AlexStocks @ma642 @mark4z @cityiron